[PATCH] D131150: [AMDGPU][SIAnnotateCF] Support Conditions Using a Common Basic Block

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp:354
+      // then/else block, we'd have pushed that block twice on the stack.
+      while (isTopOfStack(BB))
         Changed |= closeControlFlow(BB);
----------------
Could you construct a situation where the block appears more times, and not consecutively? It may be better to change the stack to a SetVector


================
Comment at: llvm/test/CodeGen/AMDGPU/si-annotate-control-flow-condition-common-blocks.ll:3
+; RUN: opt -mtriple=amdgcn-- -S -structurizecfg -si-annotate-control-flow %s | FileCheck -check-prefix=OPT %s
+
+define amdgpu_kernel void @ham(i64 %arg1, i64 %arg2) {
----------------
Add a brief comment explaining what this tests. Also, can you add an llc run line? The control flow pass pipeline is a bit fragile and subject to change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131150/new/

https://reviews.llvm.org/D131150