[PATCH] D131157: [llvm-dwarfutil] Remove redundant dependency.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks! I'm not an expert in this area, so the below might be silly questions. Apologies in advance :)



================
Comment at: llvm/tools/llvm-dwarfutil/CMakeLists.txt:6
 set(LLVM_LINK_COMPONENTS
-  ${LLVM_TARGETS_TO_BUILD}
   DebugInfoDWARF
----------------
Given that you call InitializeAllTargets(), shouldn't you keep this one and instead remove the 3 AllTargetsFoo at the bottom instead?

(`InitializeAllTargets` calls `LLVMInitialize.*Target\b` and that's in `llvm/lib/Target/Foo/FooTargetMachine.cpp`)


================
Comment at: llvm/tools/llvm-dwarfutil/llvm-dwarfutil.cpp:484
   InitializeAllAsmPrinters();
-  InitializeAllAsmParsers();
 
----------------
It's not obvious to me why this call is redundant, can you elaborate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131157/new/

https://reviews.llvm.org/D131157