[PATCH] D130621: [RISCV] Add target feature to force-enable atomics
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 4 02:58:05 PDT 2022
asb added a comment.
Just one question about the tests - typically we combine RV32 and RV64 tests in one file (this makes it easier if e.g. another operation was added or a new corner case found, as it's less likely we'd add a new case for RV32 but not RV64 or vice versa). Is there a reason you can't merge these into forced-atomics.ll?
Otherwise, looks good to me - thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130621/new/
https://reviews.llvm.org/D130621
More information about the llvm-commits
mailing list