[PATCH] D130745: [llvm-cov][WIP] Add Per Directory coverage to llvm-cov

Ashutosh Pandey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 00:39:44 PDT 2022


ashpande updated this revision to Diff 449891.
ashpande added a comment.

Updated with Debug log.
In the CoverageTreeNode struct, changed children from an array to an unordered set. This prevents the multiple child problem while building up the tree.
Tried to increase the context with -U999999, not sure if its correct now.

The patch is generating the HTML for folders but not the files. It's throwing an error saying "too many open files".

This might be because we are recursing over the tree and opening a new file each time.  Node->Name is relative path, while Node->FCS.Name is the absolute path, FCS.Name is what llvm-cov is using. Chopping strings seems to be hacky, so have to figure out a way to be relative to repository root/ user specified DIR root. This should avoid the problem of too many files being open.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130745/new/

https://reviews.llvm.org/D130745

Files:
  llvm/tools/llvm-cov/SourceCoverageViewHTML.cpp
  llvm/tools/llvm-cov/SourceCoverageViewHTML.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130745.449891.patch
Type: text/x-patch
Size: 11660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220804/e1c72b84/attachment.bin>


More information about the llvm-commits mailing list