[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 4 00:18:48 PDT 2022


pengfei added a comment.

Thanks for review!



================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6350
 
+  if (Args.hasArg(options::OPT_mindirect_branch_cs_prefix))
+    CmdArgs.push_back("-mindirect-branch-cs-prefix");
----------------
MaskRay wrote:
> pengfei wrote:
> > MaskRay wrote:
> > > This is not needed with the TableGen CC1Option change.
> > Do you have an example how to change the CC1Option? Removing the code directly won't generate the expected module flag anymore.
> OK, sorry. A statement is needed: `Args.AddLastArg(CmdArgs, options::OPT_mindirect_branch_cs_prefix); `
Good to know such usage. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130754/new/

https://reviews.llvm.org/D130754



More information about the llvm-commits mailing list