[PATCH] D130964: [X86][BF16] Enable __bf16 for x86 targets.

Freddy, Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 17:56:48 PDT 2022


FreddyYe added a comment.

> Right, but this patch is adding x86 support whenever SSE2 is available.  AVX512BF16 is available on a *very* small slice of processors.  In contrast, e.g. F16C is relatively broadly available, although I understand that we formally support `_Float16` all the way back to SSE2 and thus on some processors that lack F16C.
>
> But okay, pure intrinsic support is fine if that's what we're doing.
>
> I think the patch looks fine.

Yes. This type is for pure intrinsic support. Thanks for your review. Let's wait for the backend patch to land first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130964/new/

https://reviews.llvm.org/D130964



More information about the llvm-commits mailing list