[PATCH] D130680: [IntegerDivision][AMDGPU] Use CreateLogicalOr to block poison propagation.

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/IntegerDivision.cpp:150
 static Value *generateUnsignedDivisionCode(Value *Dividend, Value *Divisor,
                                            IRBuilder<> &Builder) {
   // The basic algorithm can be found in the compiler-rt project's
----------------
craig.topper wrote:
> aqjune wrote:
> > Should `Dividend` and `Divisor` here be frozen to address the comment?
> I don't understand the question. I froze them on line 256 and 257. Do you think they should be frozen earlier int he function or in a different basic block?
Oops, I missed the updates at 256, 257, sorry for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130680/new/

https://reviews.llvm.org/D130680