[PATCH] D131127: [llvm] Fixed a number of typos

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 16:30:05 PDT 2022


asbirlea added a comment.

Thank you for the elaborate cleanup!

Drive-by comments, didn't get to all.



================
Comment at: llvm/docs/GlobalISel/GMIR.rst:198
 This representation better supports pointers having different sizes depending
-on their addressspace.
+on their address space.
 
----------------
One word, not a typo.


================
Comment at: llvm/lib/IR/BuiltinGCs.cpp:62
 /// implementation usable with any collector which can consume the standard
-/// stackmap format generated by statepoints, uses the default addrespace to
+/// stackmap format generated by statepoints, uses the default addresspace to
 /// distinguish between gc managed and non-gc managed pointers, and has
----------------
addressspace


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1552
     return InsertBefore;
-  // Instrument generic addresses in supported addressspaces.
+  // Instrument generic addresses in supported address spaces.
   IRBuilder<> IRB(InsertBefore);
----------------
addressspaces.


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/forward-loop-independent.ll:7
+; now there is hack in LAA that tries to figure out loop-independent forward
+; dependencies *outside* of the MemoryDepChecker logic (i.e. proper dependence
 ; analysis).
----------------
s/dependencies/dependences (consistent with above)


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/stride-access-dependence.ll:111
 
-; Following cases are unsafe depdences and are not vectorizable.
+; Following cases are unsafe dependencies and are not vectorizable.
 
----------------
dependences


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131127/new/

https://reviews.llvm.org/D131127



More information about the llvm-commits mailing list