[PATCH] D128863: Add switch to use "source_filename" instead of a hash ID for globally promoted local

[Bill Wendling via Phabricator via llvm-commits]

void added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/promote-local-name.ll:20
+
+; The copy in %t1.bc should not be exported/promoted/renamed
+; RUN: llvm-lto -use-source-filename-for-promoted-locals -thinlto-action=promote %t1.bc -thinlto-index=%t3.bc -o - | llvm-dis -o - | FileCheck %s --check-prefix=NOEXPORTSTATIC
----------------
tejohnson wrote:
> I don't think there is a need for this testing here (this is behavior tested elsewhere). You should be able to remove promote-local-name-1.ll completely from this test.
I removed the extra check, but when I tried to remove one of the .ll files it fails. (I low-key don't know what the `llvm-lto` tool with all of its options does.) Can I just leave it as is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128863/new/

https://reviews.llvm.org/D128863