[PATCH] D131034: [Backend][X86] Improved tail call optimization for functions marked as musttail

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/test/CodeGen/X86/musttail-struct.ll:41
+
+; Arguments of different sizes passed on stack.
+define dso_local i32 @testManyArgs(i32 %0, i32 %1, i32 %2, i32 %3, i32 %4, i32 %5, i8 %6, ptr byval(%struct.5xi32) %7) {
----------------
huangjd wrote:
> davidxl wrote:
> > is this the correct comment, or it is intended for a negative test (missing)?
> This is just describing the purpose of the test. in x64 the first 6 are passed by register and the rest 2 are passed by stack
Ok. Can you expand the comment a little more.

Can you also add a negative test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131034/new/

https://reviews.llvm.org/D131034