[PATCH] D131092: [BOLT] Remove always true if statement

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 3 12:31:50 PDT 2022


rafauler created this revision.
Herald added a subscriber: ayermolo.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
rafauler requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Got a warning from GCC when building this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131092

Files:
  bolt/lib/Core/BinaryFunction.cpp


Index: bolt/lib/Core/BinaryFunction.cpp
===================================================================
--- bolt/lib/Core/BinaryFunction.cpp
+++ bolt/lib/Core/BinaryFunction.cpp
@@ -1227,13 +1227,10 @@
       BC.DisAsm->getInstruction(TempInst, Size, FunctionData.slice(Offset),
                                 AbsoluteInstrAddr, nulls());
       if (!BC.validateEncoding(TempInst, FunctionData.slice(Offset, Size))) {
-        if (opts::Verbosity >= 0) {
-          errs() << "BOLT-WARNING: internal assembler/disassembler error "
-                    "detected for AVX512 instruction:\n";
-          BC.printInstruction(errs(), TempInst, AbsoluteInstrAddr);
-          errs() << " in function " << *this << '\n';
-        }
-
+        errs() << "BOLT-WARNING: internal assembler/disassembler error "
+                  "detected for AVX512 instruction:\n";
+        BC.printInstruction(errs(), TempInst, AbsoluteInstrAddr);
+        errs() << " in function " << *this << '\n';
         setIgnored();
         break;
       }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131092.449741.patch
Type: text/x-patch
Size: 1032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220803/4cb83048/attachment.bin>


More information about the llvm-commits mailing list