[PATCH] D130275: [JITLink][COFF][x86_64] Implement SECTION/SECREL relocation.

[Lang Hames via Phabricator via llvm-commits]

lhames added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:1104-1108
+    assert(S == Scope::Local || llvm::count_if(AbsoluteSymbols,
+                                               [&](const Symbol *Sym) {
+                                                 return Sym->getName() == Name;
+                                               }) == 0 &&
+                                    "Duplicate absolute symbol");
----------------
lhames wrote:
> Why has the `S == Scope::Local` check been removed?
> 
> It's an odd "feature" but `LinkGraph` does permit duplicate names for local symbols, because they can crop up in real objects produced by `ld -r` and other tools.
/facepalm.

I read the change backwards. Thanks for adding the check. :)




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130275/new/

https://reviews.llvm.org/D130275