[PATCH] D130875: [Metadata] Introduce MD_pcsections

Wed Aug 3 09:07:30 PDT 2022

melver marked an inline comment as done.
melver added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/pcsections.ll:1
+; BROKEN: llc -O0 < %s | FileCheck %s --check-prefixes=CHECK,CHECK-UNOPT,DEFCM
+; BROKEN: llc -O1 < %s | FileCheck %s --check-prefixes=CHECK,CHECK-OPT,DEFCM
----------------
melver wrote:
> MaskRay wrote:
> > One RUN line for the default code model suffices. There is no codegen optimization difference.
> > 
> > A patch should not introduce disabled tests this way. If a dependent patch introduces the functionality, the test should be added to that patch.
> > 
> I don't understand. Removing any one line here will reduce coverage.
> 
> We have RUNs for each -O0 to -O3 with the default code model, and then only O1 with a large code model.
Note that e.g. on arm64 -O0 uses GlobalISel and -O1 and above use FastISel+SelectionDAG, so using different optimization levels will test different ISels. Different optimization levels have helped me catch bugs in earlier implementations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130875/new/

https://reviews.llvm.org/D130875