[PATCH] D130729: [SeparateConstOffsetFromGEP] [AMDGPU] Check legality for all uses of transformed GEP

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp:915-916
+
+    if (!InterestingCase)
+      AllUsesValid &= resolvePtrToInt(Inst, AccumulativeByteOffset, Visited);
+
----------------
Doing anything to ptrtoint/inttoptr is probably wrong


================
Comment at: llvm/test/CodeGen/AMDGPU/gep-const-address-space.ll:254-255
+
+attributes #8 = { argmemonly mustprogress nounwind willreturn "target-cpu"="gfx90a" }
+attributes #23 = { nounwind }
+
----------------
Should compact the attribute group numbers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130729/new/

https://reviews.llvm.org/D130729