[PATCH] D130729: [SeparateConstOffsetFromGEP] [AMDGPU] Check legality for all uses of transformed GEP

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D130729#3695983 <https://reviews.llvm.org/D130729#3695983>, @foad wrote:

> What's the failure mode without your patch? Can you precommit the tests?
>
> TBH I don't understand the concept of checking "legality" here. At the IR level I thought all GEPs were legal.

The point of the pass is to form GEPs that are friendly to matching the addressing modes. If an offset doesn't fit the target addressing mode, there's the potential to produce worse codegen


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130729/new/

https://reviews.llvm.org/D130729