[PATCH] D129636: Fix a LSR debug invariance issue

Wed Aug 3 03:01:29 PDT 2022

chrisjackson added a comment.

In D129636#3654504 <https://reviews.llvm.org/D129636#3654504>, @markus wrote:

> I'd still like to get some feedback from the author of the LSR debug salvaging (@chrisjackson) before proceeding as at the moment it is a bit unclear if it actually is safe to do a `SE.forgetValue()` here.

Hello, apologies, this only just came to my attention so I'm looking at it now! Possibly my phab email is misconfigured - I'll check that out and fix it.

Thanks for working on this. This seems a very interesting case. I had naively assumed getSCEV() was benign and would not result in creating extra information for the compiler's code generation. Obviously it is a problem that it does. On first glance your solution looks good, but I'll try and review in more detail.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129636/new/

https://reviews.llvm.org/D129636