[PATCH] D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP

Wed Aug 3 02:58:08 PDT 2022

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2742
+  case ISD::VP_FPTOUI:
+  case ISD::VP_SITOFP:
+  case ISD::VP_UITOFP:
----------------
Jimerlife wrote:
> frasercrmck wrote:
> > That's interesting - how come `ISD::SINT_TO_FP` and `ISD::STRICT_SINT_TO_FP` aren't handled here? Are they handled elsewhere or is there a bug somewhere?
> ISD::SINT_TO_FP and ISD::STRICT_SINT_TO_FP are handled in line 2724. Maybe I need to add VP_SITOFP and VP_UITOFP in line 2724.
Ah, nice. I didn't notice that. Yeah I think keeping them together is best. Thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130685/new/

https://reviews.llvm.org/D130685