[PATCH] D129129: CommandLine: Cleanup options and remove use of ManagedStatic

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:354
   /// This option must have been the last option registered.
   /// For testing purposes only.
   void removeArgument();
----------------
efriedma wrote:
> "This option must have been the last option registered. For testing purposes only."
> 
> Is this still accurate?  Is it an issue here?
Thanks for spotting that. I did look into that when I wrote the code and the comment looks outdated to me. I've also been using these patches for a while now and this doesn't appear to be an issue in practice. I'm going to remove the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129129/new/

https://reviews.llvm.org/D129129