[PATCH] D129122: ManagedStatic: remove from PassManagerBuilder

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:239
   // has already been destroyed; doing so should not generate an error.
-  if (!GlobalExtensions.isConstructed())
+  if (!GlobalExtensionsConstructed)
     return;
----------------
efriedma wrote:
> I don't think you've managed to quite capture the intended semantic here.  Note the comment mentions what happens after GlobalExtensions is destroyed...
I think you're right. I must've intended to add a destructor for GlobalExtensions (why else define the struct?) but then forgot...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129122/new/

https://reviews.llvm.org/D129122