[PATCH] D130862: [LegalizeTypes] Improve splitting for urem by constant for some constants.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7181
+      InH = DAG.getNode(ISD::EXTRACT_ELEMENT, dl, HiLoVT, N->getOperand(0),
+                        DAG.getIntPtrConstant(1, dl));
+    }
----------------
craig.topper wrote:
> RKSimon wrote:
> > Are you we causing any oneuse issues if we split here and then can't expand below?
> Good point. Today it's not an issue because that code only executes on the X86 win64 path and we have ADDCARRY available. But I'll fix it.
Rather than trying to create the nodes only when the below succeeds, I added an ultimate fall back for targets that don't use ZeroOrOneBooleanContent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130862/new/

https://reviews.llvm.org/D130862