[PATCH] D130815: [BOLT] Handle unclaimed PC data relocation related to jump table

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 23:02:59 PDT 2022


tschuett added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:774
+  // 5. Ignore all functions relevant to the jump table
+  std::unordered_set<JumpTable *> SkippedJTs;
+  std::unordered_set<uint64_t> UnreachableAddress;
----------------
LLVM doesn't like really `unordered_set` because it is expensive. Maybe you like some of the alternatives that LLVM offers:
https://llvm.org/docs/ProgrammersManual.html#set-like-containers-std-set-smallset-setvector-etc



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130815/new/

https://reviews.llvm.org/D130815



More information about the llvm-commits mailing list