[PATCH] D131026: stop llvm-reduce's ReduceBasicBlocks delta pass from creating invalid IR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 19:41:09 PDT 2022


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.

LGTM. I do think something is off about how the pass currently tries to auto-fold unconditional branches to successors. I was thinking there should be a separate control flow simplification to clean those up



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp:105
 
+/// a BB is ok to remove if it's not the entry block, or else it is
+/// the entry block but the next block in the function has just one
----------------
Capitalize a


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131026/new/

https://reviews.llvm.org/D131026



More information about the llvm-commits mailing list