[PATCH] D131035: Replace pdb file used in llvm-symbolizer test with a smaller file.

Amy Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 17:12:53 PDT 2022


akhuang created this revision.
akhuang added reviewers: nikic, jhenderson.
Herald added a subscriber: rupprecht.
Herald added a project: All.
akhuang requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

Reduce the size of the test-columns.pdb file from 6MB to 72KB by not
including standard libraries when building. Also update the instructions
for building the exe/pdb files.

context https://reviews.llvm.org/D81950#3692893


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131035

Files:
  llvm/test/tools/llvm-symbolizer/pdb/Inputs/test-columns.exe
  llvm/test/tools/llvm-symbolizer/pdb/Inputs/test-columns.pdb
  llvm/test/tools/llvm-symbolizer/pdb/Inputs/test.cpp
  llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test


Index: llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
===================================================================
--- llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
+++ llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
@@ -1,11 +1,11 @@
-RUN: echo 0x140006BA0 > %t.input
-RUN: echo 0x140006C00 >> %t.input
-RUN: echo 0x140006BB0 >> %t.input
-RUN: echo 0x140006C10 >> %t.input
-RUN: echo 0x140006C20 >> %t.input
-RUN: echo 0x140006C30 >> %t.input
-RUN: echo 0x140006C40 >> %t.input
-RUN: echo 0x140006C70 >> %t.input
+RUN: echo 0x140001000 > %t.input
+RUN: echo 0x140001030 >> %t.input
+RUN: echo 0x140001010 >> %t.input
+RUN: echo 0x140001040 >> %t.input
+RUN: echo 0x140001050 >> %t.input
+RUN: echo 0x140001060 >> %t.input
+RUN: echo 0x140001070 >> %t.input
+RUN: echo 0x140001080 >> %t.input
 RUN:    llvm-symbolizer --obj="%p/Inputs/test-columns.exe" < %t.input \
 RUN:    | FileCheck %s
 
Index: llvm/test/tools/llvm-symbolizer/pdb/Inputs/test.cpp
===================================================================
--- llvm/test/tools/llvm-symbolizer/pdb/Inputs/test.cpp
+++ llvm/test/tools/llvm-symbolizer/pdb/Inputs/test.cpp
@@ -1,7 +1,6 @@
-// To generate the corresponding EXE/PDB, run:
-// cl /Zi test.cpp
-// To generate the PDB with column numbers, run:
-// clang-cl /Zi -gcolumn-info test.cpp
+// To generate the corresponding EXE/PDB (add -gcolumn-info for line columns):
+// clang -cc1 -triple x86_64-pc-windows-msvc -gcodeview -debug-info-kind=constructor -emit-obj test.cpp
+// lld-link test.obj -debug -entry:main
 
 namespace NS {
 struct Foo {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131035.449491.patch
Type: text/x-patch
Size: 1588 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220803/b83e1021/attachment.bin>


More information about the llvm-commits mailing list