[PATCH] D130903: [AArch64][GlobalISel] Lower formal arguments of AAPCS & ms_abi variadic functions.
Vladislav Dzhidzhoev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 16:42:04 PDT 2022
dzhidzhoev marked an inline comment as not done.
dzhidzhoev added inline comments.
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:565
+ GPRIdx = MFI.CreateFixedObject(GPRSaveSize, -(int)GPRSaveSize, false);
+ if (GPRSaveSize & 15)
+ // The extra size here, if triggered, will always be 8.
----------------
dzhidzhoev wrote:
> paquette wrote:
> > Can you explain why this is the case in a comment? Even referencing some win64 doc would be useful?
> I'm not sure I have clean understanding of this line. It was introduced here https://reviews.llvm.org/D35720
clear*
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130903/new/
https://reviews.llvm.org/D130903
More information about the llvm-commits
mailing list