[PATCH] D130668: [libunwind] Use `_dl_find_object` if available

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 15:58:50 PDT 2022


MaskRay added inline comments.


================
Comment at: libunwind/src/AddressSpace.hpp:614
+#endif
+  // We expect `_dl_find_object` to return the the PT_GNU_EH_FRAME section.
+#if DLFO_EH_SEGMENT_TYPE != PT_GNU_EH_FRAME
----------------
typo: `the the`


================
Comment at: libunwind/src/AddressSpace.hpp:653
+    }
+    // .eh_frame_hdr records the start of .eh_frame, but not its size.
+    // Rely on a zero terminator to find the end of the section.
----------------
> .eh_frame_hdr records the start of .eh_frame

This sentence is wrong. .eh_frame_hdr is a different section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130668/new/

https://reviews.llvm.org/D130668



More information about the llvm-commits mailing list