[PATCH] D130910: [NewGVN][PHIOFOPS] Bail out if an operand is in OpSafeForPHIOfOps but it is not safe for the current basic block.
Konstantina Mitropoulou via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 13:50:12 PDT 2022
kmitropoulou marked an inline comment as done.
kmitropoulou added a comment.
In D130910#3692890 <https://reviews.llvm.org/D130910#3692890>, @foad wrote:
> I am not too familiar with NewGVN, but wouldn't it be simpler and safer to clear OpSafeForPHIOfOps in verifyIterationSettled()? It is inside `#ifndef NDEBUG` so it doesn't matter too much if it's a bit slower.
Good point! Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130910/new/
https://reviews.llvm.org/D130910
More information about the llvm-commits
mailing list