[PATCH] D130188: [DependenceAnalysis][PR56275] Normalize dependence analysis results to be non-negative when required

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 12:08:55 PDT 2022


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM, but with a renaming suggestion.



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:854
+Expected<bool> parseDependenceAnalysisPrinterOptions(StringRef Params) {
+  return parseSinglePassOption(Params, "da-print-normalized-results",
+                               "DependenceAnalysisPrinter");
----------------
I think the `da-print-` prefix is unnecessary since this is parsed for `print<da>` pass only.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130188/new/

https://reviews.llvm.org/D130188



More information about the llvm-commits mailing list