[PATCH] D129999: [TableGen] Mark MachineInstr with FrameIndex as not compressible

Piggy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 11:50:57 PDT 2022


piggynl added a comment.

In D129999#3694257 <https://reviews.llvm.org/D129999#3694257>, @craig.topper wrote:

> Can you update the title to say make "Mark MachineInstr with FrameIndex as not compressible".   The phrase "incomplete MachineInstr" is not very clear. I would interpret it as a MachineInstr with less operands than it's supposed to have. A MachineInstr with a FrameIndex is a completely valid MachineInstr so I wouldn't call it incomplete.

Thanks for the correction! I updated the revision's summary as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129999/new/

https://reviews.llvm.org/D129999



More information about the llvm-commits mailing list