[llvm] d3c4609 - [GIsel] Add missing space between type and name in GICombinerHelperArg
Kai Nacke via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 2 10:36:22 PDT 2022
Author: Kai Nacke
Date: 2022-08-02T13:35:25-04:00
New Revision: d3c4609855e161a8f7a845b42e685ce8273af09c
URL: https://github.com/llvm/llvm-project/commit/d3c4609855e161a8f7a845b42e685ce8273af09c
DIFF: https://github.com/llvm/llvm-project/commit/d3c4609855e161a8f7a845b42e685ce8273af09c.diff
LOG: [GIsel] Add missing space between type and name in GICombinerHelperArg
When using AdditionalArguments in a GICombinerHelper, the generator
does not put a space between the type and the name.
E.g.
let AdditionalArguments = [GICombinerHelperArg<"bool", "IsSomething">];
ends up as
boolIsSomething) const;
in the generated file. This change adds a space between the type and the name.
Reviewed By: aemerson
Differential Revision: https://reviews.llvm.org/D130823
Added:
Modified:
llvm/utils/TableGen/GICombinerEmitter.cpp
Removed:
################################################################################
diff --git a/llvm/utils/TableGen/GICombinerEmitter.cpp b/llvm/utils/TableGen/GICombinerEmitter.cpp
index 77e05aebf53a0..52483af8aabe3 100644
--- a/llvm/utils/TableGen/GICombinerEmitter.cpp
+++ b/llvm/utils/TableGen/GICombinerEmitter.cpp
@@ -842,7 +842,7 @@ static void emitAdditionalHelperMethodArguments(raw_ostream &OS,
Record *Combiner) {
for (Record *Arg : Combiner->getValueAsListOfDefs("AdditionalArguments"))
OS << ",\n " << Arg->getValueAsString("Type")
- << Arg->getValueAsString("Name");
+ << " " << Arg->getValueAsString("Name");
}
void GICombinerEmitter::run(raw_ostream &OS) {
More information about the llvm-commits
mailing list