[PATCH] D130397: [RISCV] Custom type legalize i32 loads by sign extending.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D130397#3690597 <https://reviews.llvm.org/D130397#3690597>, @asb wrote:

> I wonder if this should be a target hook? I accept that adding a hook for something that only RISC-V uses isn't necessarily an obvious win. But it also doesn't seem ideal for us to accrete too many of these heuristic workarounds within the backend. (not sure I have a super strong opinion either way - just raising for discussion).

This doesn't feel very different than what we do for ADD/SUB/MUL/SHL so I'm not sure its worth a target hook right now.

@asb have you checked gcc torture suite with this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130397/new/

https://reviews.llvm.org/D130397