[PATCH] D130187: [Symbolizer] Implement data symbolizer markup element.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 09:09:41 PDT 2022


peter.smith added a comment.

Apologies for the delay in responding, have been on vacation. I've got one suggestion on the output of the module line having looked at the test. Otherwise looks good to me.



================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-data.test:12
+
+CHECK: [[BEGIN:\[{3}]]ELF module #0x0 "a.o"; BuildID=abcdef 0x0(r)-0x10(r)[[END:\]{3}]]
+CHECK: long long byte
----------------
I don't know how much scope there is to change the output format of the mmap information in the module line given that this is based on a pre-existing markup. When I saw `0x0(r) - 0x10(r)` I wasn't sure whether this was one contiguous range `[0x0, 0x10)` or two separate ranges, not necessarily contiguous with one starting at `0x0` and one at `0x10`. I guessed at the latter given the `{{{mmap}}}` elements but it would have been harder to understand if I'd just seen the output and not the input.

Perhaps use a comma instead of a dash to separate the mmaps? As an alternative I guess the size could be incorporated in some way.

No worries if this isn't possible.

 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130187/new/

https://reviews.llvm.org/D130187



More information about the llvm-commits mailing list