[PATCH] D126661: [MachineVerifier] Fix crash on early clobbered subreg operands.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2275
+      }
     }
   } else {
----------------
Do we need an "else" case here? You could at least check SlotIndex::isSameInstr(VNI->def, DefIdx). And maybe check that VNI-def is the early clobber slot and DefIdx is the normal slot.

And (as @MatzeB said) maybe even scan the instruction to check that there is an early-clobber def of the same superregister somewhere. Or maybe that would be better handled by a separate check that any range with subranges has the same start idx as one of the subranges.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126661/new/

https://reviews.llvm.org/D126661