[PATCH] D130676: [AArch64] Treat x18 as callee-saved in functions with Windows calling convention on Darwin

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

In practice, Wine works mostly quite well without this compiler help feature now, so we could consider removing the whole concept of extra backup of x18 on non-Windows platforms sometime in the future too, but I think it's best to wait until Wine has completed their transition to split all code that calls into host libraries behind a syscall interface (aka the PE split).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130676/new/

https://reviews.llvm.org/D130676