[PATCH] D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham updated this revision to Diff 449257.
simon_tatham added a comment.

Addressed all review comments, I think.

I couldn't find any convenient way to make
`STI.getFeatureBits()[ARM::ModeBigEndianInstructions]` work in
`llvm-objdump.cpp`, because that tool doesn't have the right include
path to include the generated file where those enums are defined. So
I've made the prettyprinter have its own endianness flag that's set
directly at the same time as setting that feature in the
SubtargetInfo, and that will save having to check anything in the STI
at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130902/new/

https://reviews.llvm.org/D130902

Files:
  llvm/include/llvm/BinaryFormat/ELF.h
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/lib/Target/ARM/ARM.td
  llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
  llvm/test/tools/llvm-objdump/ELF/ARM/be-image-disasm.test
  llvm/test/tools/llvm-objdump/ELF/ARM/be-object-disasm.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130902.449257.patch
Type: text/x-patch
Size: 11644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220802/40688705/attachment.bin>