[PATCH] D130977: [llvm] Make split-file an utility instead of tool

Markus Böck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 2 03:16:02 PDT 2022


zero9178 created this revision.
zero9178 added reviewers: MaskRay, beanz.
Herald added subscribers: StephenFan, mgorny.
Herald added a project: All.
zero9178 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

`split-file` is essentially a development tool used for writing tests. Other related tooling for this purpose such as `FileCheck`, `count`, `not` and more are already created via `add_llvm_utility` instead of `add_llvm_tool`. The later is more meant as LLVM tools used as part of a toolchain (eg. `llvm-ar`), not for tools for the development of LLVM itself.

The main semantic difference this makes is that `split-file` is now built and installed via the `LLVM_INSTALL_UTILS` and `LLVM_BUILD_UTILS` instead of `LLVM_BUILD_TOOLS` and `LLVM_INSTALL_TOOLS` cmake flags. That way one can use `LLVM_BUILD_TOOLS=OFF LLVM_INSTALL_UTILS=ON` and have `split-file` installed along side the other testing tools.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130977

Files:
  llvm/tools/split-file/CMakeLists.txt


Index: llvm/tools/split-file/CMakeLists.txt
===================================================================
--- llvm/tools/split-file/CMakeLists.txt
+++ llvm/tools/split-file/CMakeLists.txt
@@ -2,6 +2,6 @@
   Support
   )
 
-add_llvm_tool(split-file
+add_llvm_utility(split-file
   split-file.cpp
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130977.449241.patch
Type: text/x-patch
Size: 306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220802/bb712604/attachment.bin>


More information about the llvm-commits mailing list