[PATCH] D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP

Tue Aug 2 00:48:28 PDT 2022

frasercrmck added a comment.

The change LGTM but I'd like to know why only VP INT_TO_FP nodes are handled in this code.

Just FYI I also opened D130967 <https://reviews.llvm.org/D130967>. I thought it better we keep these VP ISD nodes named in line with the non-VP ones.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2742
+  case ISD::VP_FPTOUI:
+  case ISD::VP_SITOFP:
+  case ISD::VP_UITOFP:
----------------
That's interesting - how come `ISD::SINT_TO_FP` and `ISD::STRICT_SINT_TO_FP` aren't handled here? Are they handled elsewhere or is there a bug somewhere?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130685/new/

https://reviews.llvm.org/D130685