[PATCH] D130868: [LV] Refactor getExtendedAddReductionCost to support other extended reduction more than Add.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan marked 2 inline comments as done.
jacquesguan added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:2351
+        thisT()->getArithmeticInstrCost(Instruction::Mul, ExtTy, CostKind);
+    ExtCost *= 2;
 
----------------
dmgreen wrote:
> Fold the ExtCost *= 2 into the return statement below?
Done.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1708
+    break;
+  // TODO: Add other Op, for example: FADD?
+  default:
----------------
dmgreen wrote:
> You can remove this - there are no other ops under MVE
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130868/new/

https://reviews.llvm.org/D130868