[PATCH] D130931: [RISCV] Teach RISCVMergeBaseOffset to merge %lo/%pcrel_lo into load/store after folding arithmetic.
    Luís Marques via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Aug  1 14:58:02 PDT 2022
    
    
  
luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.
LGTM.
(I wonder if it's worth adding a read-modify-write-addi-addi test case as well?)
================
Comment at: llvm/lib/Target/RISCV/RISCVMergeBaseOffset.cpp:332-333
+
   // We didn't find an arithmetic instruction. If all the uses are memory ops
   // with the same offset, we can transform:
   //
----------------
Nit: needs updating
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130931/new/
https://reviews.llvm.org/D130931
    
    
More information about the llvm-commits
mailing list