[PATCH] D126661: [MachineVerifier] Fix crash on early clobbered subreg operands.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 13:23:04 PDT 2022


MatzeB added a comment.

Sorry, but at a first glance this looks like you are just disabling verifier checks.

The summary says that `checkLivenessAtDef()` would ignore that something is a subreg definition, but there are `SubRangeCheck` parameters and a `LaneMask` parameter, so this doesn't seem to be true in general.

Is this really an incorrect check? Or does LLVM compute wrong liveness information?

Could you share a dump of the computed liveintervals for the given example here? (I don't have an amdgpu-enabled build ready at the moment).



================
Comment at: llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir:1
+# RUN: llc -mtriple amdgcn-amd-amdhsa -run-pass=liveintervals,pipeliner -verify-machineinstrs -o - %s | FileCheck %s
+# REQUIRES: amdgpu-registered-target
----------------
Why not just `-run-pass=liveintervals`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126661/new/

https://reviews.llvm.org/D126661



More information about the llvm-commits mailing list