[PATCH] D123264: [RISCV] Pre-RA expand pseudos pass

Mon Aug 1 13:07:29 PDT 2022

craig.topper added a comment.

In D123264#3691830 <https://reviews.llvm.org/D123264#3691830>, @leonardchan wrote:

> In D123264#3691824 <https://reviews.llvm.org/D123264#3691824>, @craig.topper wrote:
>
>> In D123264#3691798 <https://reviews.llvm.org/D123264#3691798>, @leonardchan wrote:
>>
>>> Hi I think this patch led to the following ICEs seen on our windows builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8807088318544910865/overview):
>>>
>>>   96/151] Building C object CMakeFiles/clang_rt.builtins-riscv64.dir/floatdidf.c.obj
>>>   FAILED: CMakeFiles/clang_rt.builtins-riscv64.dir/floatdidf.c.obj 
>>>   C:\b\s\w\ir\x\w\staging\llvm_build\.\bin\clang.exe -DVISIBILITY_HIDDEN  --target=riscv64-unknown-fuchsia -IC:/b/s/w/ir/x/w/cipd/sdk/pkg/sync/include -IC:/b/s/w/ir/x/w/cipd/sdk/pkg/fdio/include   -DCOMPILER_RT_HAS_FLOAT16 -std=c11 -fPIC -fno-builtin -fvisibility=hidden -fomit-frame-pointer -o CMakeFiles/clang_rt.builtins-riscv64.dir/floatdidf.c.obj   -c C:/b/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/builtins/floatdidf.c
>>>   Unhandled encodeInstruction length!
>>>   UNREACHABLE executed at C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\lib\Target\RISCV\MCTargetDesc\RISCVMCCodeEmitter.cpp:209!
>>>   PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
>>>   Stack dump:
>>>   0.	Program arguments: C:\\b\\s\\w\\ir\\x\\w\\staging\\llvm_build\\.\\bin\\clang.exe -DVISIBILITY_HIDDEN --target=riscv64-unknown-fuchsia -IC:/b/s/w/ir/x/w/cipd/sdk/pkg/sync/include -IC:/b/s/w/ir/x/w/cipd/sdk/pkg/fdio/include -DCOMPILER_RT_HAS_FLOAT16 -std=c11 -fPIC -fno-builtin -fvisibility=hidden -fomit-frame-pointer -o CMakeFiles/clang_rt.builtins-riscv64.dir/floatdidf.c.obj -c C:/b/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/builtins/floatdidf.c
>>>   1.	<eof> parser at end of file
>>>   2.	Code generation
>>>   3.	Running pass 'Function Pass Manager' on module 'C:/b/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/builtins/floatdidf.c'.
>>>   4.	Running pass 'RISCV Assembly Printer' on function '@__floatdidf'
>>>   Exception Code: 0xC000001D
>>>    #0 0x00007ff6a2ebbcb6 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x6dbcb6)
>>>    #1 0x00007ff6a6d19bcb (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x4539bcb)
>>>    #2 0x00007ff6a6d0f0d0 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x452f0d0)
>>>    #3 0x00007ff6a2e7e175 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x69e175)
>>>    #4 0x00007ff6a374a155 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0xf6a155)
>>>    #5 0x00007ff6a2c350aa (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x4550aa)
>>>    #6 0x00007ff6a3b6669c (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x138669c)
>>>    #7 0x00007ff6a29197c8 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x1397c8)
>>>    #8 0x00007ff6a30cd61e (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x8ed61e)
>>>    #9 0x00007ff6a2918d43 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x138d43)
>>>   #10 0x00007ff6a31301ca (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x9501ca)
>>>   #11 0x00007ff6a2b000f8 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x3200f8)
>>>   #12 0x00007ff6a2b070cc (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x3270cc)
>>>   #13 0x00007ff6a2b00829 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x320829)
>>>   #14 0x00007ff6a3d77231 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x1597231)
>>>   #15 0x00007ff6a4176f58 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x1996f58)
>>>   #16 0x00007ff6a58a9e4e (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x30c9e4e)
>>>   #17 0x00007ff6a40d5484 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x18f5484)
>>>   #18 0x00007ff6a302fc23 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x84fc23)
>>>   #19 0x00007ff6a30c4dc4 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x8e4dc4)
>>>   #20 0x00007ff6a27e7abe (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x7abe)
>>>   #21 0x00007ff6a27e4848 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x4848)
>>>   #22 0x00007ff6a3e87636 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x16a7636)
>>>   #23 0x00007ff6a2e7ca22 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x69ca22)
>>>   #24 0x00007ff6a3e872cf (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x16a72cf)
>>>   #25 0x00007ff6a2fed54a (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x80d54a)
>>>   #26 0x00007ff6a2fed7af (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x80d7af)
>>>   #27 0x00007ff6a3006cfb (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x826cfb)
>>>   #28 0x00007ff6a27e418f (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x418f)
>>>   #29 0x00007ff6a6cfadf0 (C:\b\s\w\ir\x\w\staging\llvm_build\bin\clang.exe+0x451adf0)
>>>   #30 0x00007ff90b9f7974 (C:\Windows\System32\KERNEL32.DLL+0x17974)
>>>   #31 0x00007ff90e73a2f1 (C:\Windows\SYSTEM32\ntdll.dll+0x5a2f1)
>>>   clang: error: clang frontend command failed due to signal (use -v to see invocation)
>>>   Fuchsia clang version 16.0.0 (https://llvm.googlesource.com/llvm-project 260a64106854986a981e49ed87ee740460a23eb5)
>>>   Target: riscv64-unknown-fuchsia
>>>   Thread model: posix
>>>   InstalledDir: C:\b\s\w\ir\x\w\staging\llvm_build\.\bin
>>>   clang: note: diagnostic msg: 
>>>   ********************
>>>   
>>>   PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
>>>   Preprocessed source(s) and associated run script(s) are located at:
>>>   clang: note: diagnostic msg: C:\b\s\w\ir\x\t\floatdidf-9493d4.c
>>>   clang: note: diagnostic msg: C:\b\s\w\ir\x\t\floatdidf-9493d4.sh
>>>   
>>>   clang: note: diagnostic msg: 
>>>   
>>>   
>>>   
>>>   ********************
>>>
>>> Would you be able to send out a fix or revert?
>>
>> Are you able to provide the preprocessed source file floatdidf-9493d4.c from the crash dump?
>
> At the moment, no. I can try to reproduce it though that will take some time.

Nevermind, that reproduced quite easily with `./bin/clang --target=riscv64-unknown-fuchsia ../compiler-rt/lib/builtins/floatdidf.c`. I'll look at it right after I finish lunch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123264/new/

https://reviews.llvm.org/D123264