[PATCH] D130862: [LegalizeTypes] Improve splitting for urem by constant for some constants.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 11:15:29 PDT 2022


nickdesaulniers added a comment.

Can we add an additional test to llvm/test/CodeGen/ARM/div.ll that `urem` with a small constant does not produce a libcall to `__aeabi_uldivmod`? The change to llvm/lib/Target/X86/X86ISelLowering.cpp makes me wonder how many backend-specific changes are necessary here. Also, not sure if this is something we only want to do for `-O2` (vs `-Os`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130862/new/

https://reviews.llvm.org/D130862



More information about the llvm-commits mailing list