[PATCH] D130316: [SelectionDAG] make INLINEASM_BR use MachineBasicBlocks instead of BlockAddresses
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 1 10:19:17 PDT 2022
nickdesaulniers added a comment.
In D130316#3673721 <https://reviews.llvm.org/D130316#3673721>, @nikic wrote:
> I like the change, but I'm not familiar enough with the backend to fully understand the implications. The main thing I'd worry about is that more places that currently check hasAddressTaken() would also need to check isInlineAsmBrIndirectTarget(). E.g. I see more calls to the method in IfConversion. (Would it make sense to stop using blockaddresses, but still mark the MBBs are address-taken?)
Done; PTAL. Sorry for the delay, was offline most of last week.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130316/new/
https://reviews.llvm.org/D130316
More information about the llvm-commits
mailing list