[PATCH] D130776: [IRBuilder] CreateIntrinsic with implicit mangling

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 08:14:20 PDT 2022


foad added a comment.

> It seems to me that handling varargs wouldn't be a huge effort so maybe best to already take care of it? Basically, check whether the table has at least two entries (i.e. there are arguments) and the last one is a VarArg kind. If so, truncate the ArgTys to the number of argument table entries before doing the match.

I did try but I failed. I would need to spend some more time to understand why the interface provided by `Intrinsic::matchIntrinsicVarArg` works the way it does. So I would prefer to get the current patch approved first if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130776/new/

https://reviews.llvm.org/D130776



More information about the llvm-commits mailing list