[PATCH] D123693: Transform illegal intrinsics to V_ILLEGAL

[Leon Clark via Phabricator via llvm-commits]

Leonc marked an inline comment as done.
Leonc added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:3364
+
+def V_ILLEGAL_ALL_SET : Enc32, InstSI<(outs), (ins), "v_illegal_all_set"> {
+  let Inst{31-0} = 1;
----------------
bcahoon wrote:
> Do we want different mnemonics, or should the same mnemonic be used for the cases when the encoding is all 0's or all 1's?
> 
> When you add the llvm-mc tests, it will also be a good idea to add a test that pipes the output of llvm-mc through llvm-objdump to the that the different encodings show up properly for the two cases.
> Do we want different mnemonics, or should the same mnemonic be used for the cases when the encoding is all 0's or all 1's?

@arsenm asked for separate definitions:

> I would prefer to define a separate V_ILLEGAL that uses all 1s pre gfx10




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123693/new/

https://reviews.llvm.org/D123693