[PATCH] D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD

[Lorenzo Albano via Phabricator via llvm-commits]

loralb added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1936
+        MachinePointerInfo(SLD->getPointerInfo().getAddrSpace()), HiMemVT,
+        SLD->getOriginalAlign(), MachineMemOperand::MOLoad, SLD->getAAInfo(),
+        SLD->getRanges(), SLD->isExpandingLoad());
----------------
craig.topper wrote:
> This will create a MachineMemOperand with size based on HiMemVT, but I don't think that's correct. We need UnknownSize.
In [[ https://github.com/llvm/llvm-project/blob/ff5ae948a72307fcd6b3be9ddf2d3b9349e02caf/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp#L8231 | getStridedLoadVP ]] the MachineMemOperand is created using `MemoryLocation::UnknownSize`, isn't this correct?
Anyway, I noticed how in `SplitVecOp_VP_STRIDED_STORE` I actually create the MachineMemOperand before invoking `getStridedStoreVP`, so for consistency I could do the same here, what do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121784/new/

https://reviews.llvm.org/D121784