[PATCH] D130839: [DAG] FoldConstantArithmetic - add initial support for undef elements in bitcasted binop constant folding

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 04:05:43 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5589
+          if (!(IsUndef1 || IsUndef2))
+            Fold = FoldValue(Opcode, C1, C2);
+          else if (Opcode == ISD::AND || Opcode == ISD::MUL)
----------------
xiangzhangllvm wrote:
> Do we need to make sure the C1 C2 has no other uses ?
I don't think we have any one use limits on constant folding?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130839/new/

https://reviews.llvm.org/D130839



More information about the llvm-commits mailing list