[PATCH] D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR

[Dominik Adamski via Phabricator via llvm-commits]

domada marked 3 inline comments as done.
domada added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:622
+  /// \param NamePrefix Optional name prefix for if.then if.else blocks.
+  void createIfVersion(CanonicalLoopInfo *Loop, Value *IfCond,
+                       ValueToValueMapTy &VMap, const Twine &NamePrefix = "");
----------------
Meinersbur wrote:
> This could be made private as front-ends are encouraged to use the `IfCond` argument for the relevant instead that may implement specialized behavior (like passing the value to the runtime).
> 
> It still might be useful for front-ends (eg implementing dynamic metadirective), but I'd wait to such use cases to occur before adding this to the public API.
> 
> Edit: I noticed it is tested in the unit test, which requires it to be public.
I moved it to private and I  removed corresponding unit test. This functionality is also tested by applySimdLoopIf unit test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129368/new/

https://reviews.llvm.org/D129368