[llvm] 5b1d10b - [AA] Drop setModAndRef() function (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 31 22:56:20 PDT 2022


Author: Nikita Popov
Date: 2022-08-01T07:55:39+02:00
New Revision: 5b1d10bda60a1737c5c2785d9ec54806047fe49d

URL: https://github.com/llvm/llvm-project/commit/5b1d10bda60a1737c5c2785d9ec54806047fe49d
DIFF: https://github.com/llvm/llvm-project/commit/5b1d10bda60a1737c5c2785d9ec54806047fe49d.diff

LOG: [AA] Drop setModAndRef() function (NFC)

Without the "must" state, this function is pointless, because we
can just directly create a ModRef instead.

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/AliasAnalysis.h
    llvm/lib/Analysis/AliasAnalysis.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/AliasAnalysis.h b/llvm/include/llvm/Analysis/AliasAnalysis.h
index eeb1eb3dfb1e..438702f55097 100644
--- a/llvm/include/llvm/Analysis/AliasAnalysis.h
+++ b/llvm/include/llvm/Analysis/AliasAnalysis.h
@@ -176,9 +176,6 @@ LLVM_NODISCARD inline ModRefInfo setMod(const ModRefInfo MRI) {
 LLVM_NODISCARD inline ModRefInfo setRef(const ModRefInfo MRI) {
   return ModRefInfo(static_cast<int>(MRI) | static_cast<int>(ModRefInfo::Ref));
 }
-LLVM_NODISCARD inline ModRefInfo setModAndRef(const ModRefInfo MRI) {
-  return ModRefInfo::ModRef;
-}
 LLVM_NODISCARD inline ModRefInfo clearMod(const ModRefInfo MRI) {
   return ModRefInfo(static_cast<int>(MRI) & static_cast<int>(ModRefInfo::Ref));
 }

diff  --git a/llvm/lib/Analysis/AliasAnalysis.cpp b/llvm/lib/Analysis/AliasAnalysis.cpp
index 7887c76b0f71..0d8da687bf04 100644
--- a/llvm/lib/Analysis/AliasAnalysis.cpp
+++ b/llvm/lib/Analysis/AliasAnalysis.cpp
@@ -210,7 +210,7 @@ ModRefInfo AAResults::getModRefInfo(Instruction *I, const CallBase *Call2,
   const MemoryLocation DefLoc = MemoryLocation::get(I);
   ModRefInfo MR = getModRefInfo(Call2, DefLoc, AAQI);
   if (isModOrRefSet(MR))
-    return setModAndRef(MR);
+    return ModRefInfo::ModRef;
   return ModRefInfo::NoModRef;
 }
 


        


More information about the llvm-commits mailing list