[PATCH] D130250: [LoongArch] Support for varargs

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added a comment.

The test cases seem sane enough (after some hard thought). Anyway let's wait for someone more professional than me to take a look ;-)



================
Comment at: llvm/lib/Target/LoongArch/LoongArchFrameLowering.cpp:202
 
+// Not preserve stack space within prologue for outgoing variables when the
+// function contains variable size objects.
----------------
nit: "Do not ... if ..."


================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1184
+  unsigned GRLenInBytes = Subtarget.getGRLen() / 8;
+  // Used with vargs to acumulate store chains.
+  std::vector<SDValue> OutChains;
----------------
"varargs"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130250/new/

https://reviews.llvm.org/D130250