[PATCH] D125444: [M68k] Add MC support for link/unlk

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM
Thank you! I only have some minor comments.

In D125444#3659427 <https://reviews.llvm.org/D125444#3659427>, @0x59616e wrote:

> Something worth noting about:
>
> - I guess the ".cfi_*" stuff may be wrong. Not sure about it.
> - The assembly in link-unlink.ll, other than link/unlink itself, seems to be wrong. Bugs may exist somewhere.

Yeah we can fix those later.



================
Comment at: llvm/test/CodeGen/M68k/link-unlnk.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=m68k-linux-gnu %s -verify-machineinstrs -o - | FileCheck %s
+
----------------
Can we have checks for cases in the absence of frame pointer, too? One way to do this is using the command line flag `-frame-pointer=none/all` to toggle frame pointer instead of using the function attribute (i.e. #0).


================
Comment at: llvm/test/MC/M68k/Data/Classes/MxLink.s:1
+; RUN: llvm-mc -assemble --show-encoding -triple=m68k %s | FileCheck %s
+
----------------
nit: remove `-assemble`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125444/new/

https://reviews.llvm.org/D125444